Bug 53372

Summary:	[GSOC] Improve reading usermodel objects from EscherAggregate
Product:	POI	Reporter:	Evgeniy Berlog <superrubiroyd>
Component:	HSSF	Assignee:	POI Developers List <dev>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	P2
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	All
Bug Depends on:
Bug Blocks:	53010
Attachments:	patch Added tests for fixed bug and for new model file for test improved patch

Description Evgeniy Berlog 2012-06-06 17:33:37 UTC

Created attachment 28896 [details]
patch

1. Fixed bug: "Data that follows after main spgr container is not saved in EscherAggregate.serialize()"

2. commented out methods "convertRecordsToUserModel()" and "convertUserModelToRecords()". Added method which purpose is to create HSSFShape tree from EscherRecords and ObjRecord. Added simple unit tests to compare count of spContainer(shapes), and spgrContainer(shapeGroup)

Several existing tests don't work now because we should reimplement HSSFShape subclasses

Comment 1 Evgeniy Berlog 2012-06-07 10:19:11 UTC

Created attachment 28899 [details]
Added tests for fixed bug and for new model

Comment 2 Evgeniy Berlog 2012-06-07 22:17:43 UTC

Created attachment 28903 [details]
file for test

Comment 3 Evgeniy Berlog 2012-06-08 14:37:35 UTC

Created attachment 28906 [details]
improved patch

Comment 4 Yegor Kozlov 2012-06-08 17:48:02 UTC

Applied in r1348168

(In reply to comment #3)
> Created attachment 28906 [details]
> improved patch