Bug 53374

Summary: DataSourceFactory does not support commitOnReturn property
Product: Tomcat Modules Reporter: Suresh Avadhanula <avadhanula>
Component: jdbc-poolAssignee: Tomcat Developers Mailing List <dev>
Severity: normal    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X 10.4   
Attachments: Patch for the fix.
Cleaned up Patch for the fix

Description Suresh Avadhanula 2012-06-06 20:56:47 UTC
DataSourceFactory does not support commitOnReturn property.
DataSourceFactory.ALL_PROPERTIES and DataSourceFactory.parsePoolProperties() omit commitOnReturn property.
Comment 1 Suresh Avadhanula 2012-06-06 21:01:53 UTC
Created attachment 28897 [details]
Patch for the fix.

Attaching the patch for the fix to support commitOnReturn in DataSourceFactory.
Comment 2 Konstantin Kolinko 2012-06-06 21:37:52 UTC
Comment on attachment 28897 [details]
Patch for the fix.

You patch includes a lot of formatting changes. This is a no-go. Please include only changes relevant to your fix.

Those seem to be



+        value = properties.getProperty(PROP_COMMIT_ON_RETURN);
+        if (value != null) {
+            poolProperties.setCommitOnReturn(Boolean.parseBoolean(value));
+        }
Comment 3 Suresh Avadhanula 2012-06-06 22:11:11 UTC
Created attachment 28898 [details]
Cleaned up Patch for the fix

Cleaned up the formatting changes. Including only the relevant changes.
Comment 4 Konstantin Kolinko 2012-06-08 13:17:22 UTC
Fixed by r1348056 and will be in 7.0.28