| Summary: | DataSourceFactory does not support commitOnReturn property | ||
|---|---|---|---|
| Product: | Tomcat Modules | Reporter: | Suresh Avadhanula <avadhanula> |
| Component: | jdbc-pool | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X 10.4 | ||
| Attachments: |
Patch for the fix.
Cleaned up Patch for the fix |
||
|
Description
Suresh Avadhanula
2012-06-06 20:56:47 UTC
Created attachment 28897 [details]
Patch for the fix.
Attaching the patch for the fix to support commitOnReturn in DataSourceFactory.
Comment on attachment 28897 [details]
Patch for the fix.
You patch includes a lot of formatting changes. This is a no-go. Please include only changes relevant to your fix.
Those seem to be
- PROP_ALTERNATE_USERNAME_ALLOWED
+ PROP_ALTERNATE_USERNAME_ALLOWED,
+ PROP_COMMIT_ON_RETURN
and
+ value = properties.getProperty(PROP_COMMIT_ON_RETURN);
+ if (value != null) {
+ poolProperties.setCommitOnReturn(Boolean.parseBoolean(value));
+ }
+
Created attachment 28898 [details]
Cleaned up Patch for the fix
Cleaned up the formatting changes. Including only the relevant changes.
|