Bug 53465

Summary: mapped-name is read when in @Resource, but not when in web.xml
Product: Tomcat 7 Reporter: Violeta Georgieva <violetagg>
Component: CatalinaAssignee: Tomcat Developers Mailing List <dev>
Severity: normal    
Priority: P2    
Version: 7.0.28   
Target Milestone: ---   
Hardware: PC   
OS: All   
Attachments: Patch proposal

Description Violeta Georgieva 2012-06-25 20:31:48 UTC
Created attachment 28995 [details]
Patch proposal


When I have the code below in a servlet

	private DataSource ds;

'mapped name' is read when @Resource is processed (org.apache.catalina.startup.WebAnnotationSet.addResource(WebAnnotationSet.java:377)) so later on it is available through Reference object as StringRefAddr

But when I have the declaration below in web.xml


'mapped name' is not read at all.

I would like to propose a patch that adds additional Rule to WebRuleSet so that 'mapped name' is process and set as property.

I'm looking forward to your comments.

Violeta Georgieva
Comment 1 Mark Thomas 2012-06-26 22:04:50 UTC
Thanks for the proposed patch. I extended it to cover all resource types and applied it trunk and 7.0.x. It will be included in 7.0.29 onwards.