Summary: | Creation of the test report (xml, plain) ends with a java.lang.OutOfMemoryError exception | ||
---|---|---|---|
Product: | Ant | Reporter: | Branislav Hanáček <branislav.hanacek> |
Component: | Core | Assignee: | Ant Notifications List <notifications> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | dtrebbien, jglick |
Priority: | P2 | Keywords: | PatchAvailable |
Version: | 1.9.1 | ||
Target Milestone: | 1.9.4 | ||
Hardware: | PC | ||
OS: | All | ||
Attachments: |
Patch for the DOMElementWriter class
Alternative patch Test program |
Description
Branislav Hanáček
2012-11-15 12:30:07 UTC
1. Rather than moving and renaming the encodedata() method, why not make the necessary changes in place? This way, history is better preserved. 2. The new implementation is not correct. It writes out "]]]]><![CDATA[>" as soon as it sees "]]", but this means that "]]>" is replaced with "]]]]><![CDATA[>>". What you could do is write out "]]]]><![CDATA[" instead. Though, this slightly changes the behavior (i.e. instead of escaping "]]>", it actually escapes "]]") and the JavaDoc comment would need to be updated. 3. Because characters are written individually in the new code, there is likely a negative impact on performance. Created attachment 29734 [details] Alternative patch https://github.com/dtrebbien/ant/commit/3b44cab456780e9976acdbe39b74c5f09f351a27 Created attachment 29735 [details]
Test program
I used this test program to check my suggested implementation of encodedata(Writer, String).
slipped into svn revision 1556001 by accident when it should have been a separate commit. second part is svn revision 1556004 |