| Summary: | Patch with some refactoring of Member.java [PATCH proposed for TC7] | ||
|---|---|---|---|
| Product: | Tomcat 7 | Reporter: | Greg Turnquist <greg.l.turnquist> |
| Component: | Cluster | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | enhancement | ||
| Priority: | P2 | ||
| Version: | trunk | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | patch file made against tomcat trunk | ||
Comment on attachment 29779 [details]
patch file made against tomcat trunk
Correct MIME Type. Mark as patch.
I tagged it as patch, but can't seem to change mime type. A minor variation of this patch has been applied to trunk and proposed for 7.0.x. RTC is being used for 7.0.x because of the API change. It should be safe but I'd prefer other committers to review it before it is committed. Patch looks good to me. I like the cleanup of using the interface. Too much time has passed (3 years since the original proposal). Given that 8.0.x has this patch and that we don't want to change the API in 7.0.x unless we have to, I am resolving this as WONTFIX specifically for 7.0.x. |
Created attachment 29779 [details] patch file made against tomcat trunk Attached is a patch file where I went through looking for usage of concrete class MemberImpl, and when possible, replaced it with the interface Member. I added a few (maybe three) methods to the Member interface definition to support those changes. I ran the entire test suite, and the only tests that failed were already failing without my changes (org.apache.catalina.websocket.TestWebSocket, so I don't think those are related to mine.