| Summary: | can't use keyboard to Add elements with right-click menu | ||
|---|---|---|---|
| Product: | JMeter - Now in Github | Reporter: | rikard_edgren <rikard.edgren> |
| Component: | Main | Assignee: | JMeter issues mailing list <issues> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | p.mouawad, top.hope2597 |
| Priority: | P3 | Keywords: | PatchAvailable |
| Version: | 4.0 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: |
Current WIP.
Updated Patch. Second attempt. 3rd ugly attempt My fix for JMeter 4.1-Snapshot |
||
|
Description
rikard_edgren
2013-04-02 11:35:44 UTC
I am looking to implement this. Where exactly do we think the popup should appear: 1. always in the same place (i.e. top left of the tree) or 2. top left of the element you have selected, or maybe 3. middle of the element you have selected? Using Windows Explorer as Oracle, I would say that close to upper left corner of selected element is fine. Crossing my fingers that this gets into the product! /Rikard Created attachment 32127 [details]
Current WIP.
I've almost got it working - however there seems to be a bug whereby after adding a thread group then a controller then, for example, adding a timer, it adds the element but leaves the popup menu still displayed.
The main points are:
- displayPopUp method in GuiPackage.java
- keyPressed in JMeterTreeListener.java
- makeMenuItem in MenuFactory.java
P.S. Sorry for the code tidy-up related changes also in this patch - if it makes it too hard to read I can try to pull the salient changes to a new patch.
Thanks.
Hello Graham, Thanks a lot for contribution. Unfortunately attached patch is not very readable and I am not able to apply it easily. It is showing lot of conflicts. Could you submit a new patch based on nightly build ? I think for now, we should avoid formatting patches . Thanks Created attachment 32128 [details]
Updated Patch.
I've updated the patch and applied it to current trunk.
Hi Graham,
Thanks for patch.
I tested it, I don't reproduce your issue but I faced another one.
If I select Thread Group to add, it adds setup Thread Group.
I removed from MenuFactory#makeMenuItem as it does not seem useful to me:
newMenuChoice.registerKeyboardAction(ActionRouter.getInstance(),
actionCommand,
KeyStrokes.ENTER,
JMenuItem.WHEN_IN_FOCUSED_WINDOW); // Bug 54784
and it worked fine.
Can you make some further tests on Windows or Linux ?
Thanks
If I remove that line in Ubuntu 14.04 using xfce and Oracle Java 7 it then doesn't do anything when pressing enter - no idea how the behaviour can be so different. I can't see why it sometimes adds a different element to the one which was selected. I've also notice two other bugs, but am not sure how to fix them: - If you add a config element (or timer and probably more) the popup menu doesn't hide I've tried this in Linux (Java 7) and Win 7 (Java 8) - If you press enter after adding an element, i.e. once the popup menu has closed, it just keeps adding more elements to the tree. Hopefully someone else with more knowledge of java awt, swing and/or the JM UI is able to help? Created attachment 32314 [details]
Second attempt.
My second attempt, seems to work now, i.e. none of the previous three issues, at least on Linux. Although my solution doesn't feel very neat i.e. the MenuKeyListener maybe should be moved, but then again it's not that big.
Hi, Thanks for this new patch. Unfortunately it is not working on MacOSX, when I enter after selecting Thread Group GUI is blocked and I cannot do anything except quit. I will try to have a look these upcoming days. Regards Created attachment 32482 [details]
3rd ugly attempt
Created attachment 35812 [details]
My fix for JMeter 4.1-Snapshot
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3088 |