|Summary:||Enhancements to TestFormAuthenticator|
|Product:||Tomcat 8||Reporter:||Brian Burch <Brian>|
|Component:||Catalina||Assignee:||Tomcat Developers Mailing List <dev>|
|Attachments:||svn diff: update to test class|
Description Brian Burch 2013-05-09 14:33:23 UTC
Created attachment 30266 [details] svn diff: update to test class I have attached an extensive patch to this existing test class. The main benefit is better comments and self-documenting arguments to the common worker methods, which should be helpful to anyone investigating tomcat authentication behaviour but who does not have a detailed understanding of its internal logic. The motive and techniques used here bring the source into line with an earlier enhancement to the TestNonLoginAndBasicAuthenticator, i.e. https://issues.apache.org/bugzilla/show_bug.cgi?id=54190#c4 All tests should pass with the latest trunk. Code style should be acceptable.
Comment 1 Mark Thomas 2013-05-28 11:09:21 UTC
Thanks for the patch. Applied (with one minor change) to trunk and 7.0.x and will be included in 7.0.41 onwards.