| Summary: | Update MANIFEST.MF for OSGi headers | ||
|---|---|---|---|
| Product: | Tomcat Modules | Reporter: | Martin Lichtin <lichtin> |
| Component: | jdbc-pool | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | Updated Import-/Export-Package headers (created using bnd) | ||
Hi, In the patch you specify in the Export-Package header: org.apache.tomcat.jdbc.pool.interceptor;uses:="org.apache.tomcat.jdbc.pool,org.apache.juli.logging,javax.management.openmbean,org.apache.tomcat.jdbc.pool.jmx,javax.management";version="@VERSION@" I cannot find any of the classes in package org.apache.tomcat.jdbc.pool.interceptor to use package org.apache.tomcat.jdbc.pool.jmx. Can you please check that? Against which sources did you run bnd tool? I'm checking tomcat 7 trunk. Regards Violeta I took the 7.0.40 sources artifact, as far as I can remember. However, when getting the sources from trunk and using the Felix bundle plugin, the same import/export headers are generated. I don't understand why Bnd (http://www.aqute.biz/Bnd/Bnd) thinks the "interceptor" package is using classes from "jmx", but then again, I have never questioned Bnd's outcome either, because the creation of import/export headers is normally done under the hood. Please feel free to remove "org.apache.tomcat.jdbc.pool.jmx" from the uses: clause of org.apache.tomcat.jdbc.pool.interceptor. The rest, as far as I can see, is adequate. Fixed in trunk and 7.0.x and will be included in 7.0.42 onwards. |
Created attachment 30344 [details] Updated Import-/Export-Package headers (created using bnd) The jdbc-pool/resources/MANIFEST.MF should be updated with correct Export-/Import-Package headers.