Summary: | Creating a new AreaPtg from an existing instance on same row/column inverts the "absolute" row/column attribute | ||
---|---|---|---|
Product: | POI | Reporter: | Christopher Brown <brown> |
Component: | XSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | brown |
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | Macintosh | ||
OS: | All | ||
Attachments: | Proposed test case for this issue |
Description
Christopher Brown
2013-06-03 11:16:59 UTC
Any chance you could turn this into a failing unit test? (That'll make the process of fixing it, and ensuring it stays fixed much quicker) I could try to create the unit test... I've never fixed anything on an Apache project, so I'm unfamiliar with the conventions. How would I go about it: do you have an example of how to run it and a pointer to a subversion folder where it would be recommended to put this test? It looks as if the fix could be as simple as changing the comparison operator in both "if" blocks in the constructor to use the ">=" (greater than or equals) operator instead of the ">" (greater than) operator. http://poi.apache.org/guidelines.html has some guidance A unit test will normally live in the same package as the thing it tests, but in a different folder (eg src/testcases/org/apache/foo vs src/java/org/apache/foo) If you're having issues, best ask for advice on the dev list Created attachment 30529 [details]
Proposed test case for this issue
Here's the test case, I think you'll need to deal with adding it to the source tree as I'm not a committer.
Each of the four assertions fails, obviously with the first one failing, the next ones can't run.
|