Bug 55064

Summary:	Useless processing in ReportTreeListener.isValidDragAction()
Product:	JMeter - Now in Github	Reporter:	Adrian Nistor <nistor1>
Component:	Main	Assignee:	JMeter issues mailing list <issues>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nistor1, p.mouawad
Priority:	P2	Keywords:	PatchAvailable
Version:	2.9
Target Milestone:	---
Hardware:	All
OS:	All
Attachments:	patch

Description Adrian Nistor 2013-06-05 17:57:32 UTC

Created attachment 30399 [details]
patch

The problem appears in version 2.9 and in revision 1489981.  I
attached a one-line patch that fixes it.  This problem and the patch
are similar to the previously fixed Bug 55056.

In method "ReportTreeListener.isValidDragAction", the loop over "path"
should break immediately after "isValid" is set to "false".  All the
iterations after "isValid" is set to "false" do not perform any useful
work, at best they just set "isValid" again to "false".

Method "include" in class "ClassFilter" has a similar loop (over
"pkgs"), and this loop breaks immediately after "inc" is set to
"true", just like in the proposed patch.  Other methods (e.g.,
"Copy.keepOnlyAncestors", "JMeterThread.getSampleListeners",
"HTTPSamplerBase.getSendParameterValuesAsPostBody",
"LogFilter.incFile") also have similar loops with similar breaks, just
like in the proposed patch.

Comment 1 Philippe Mouawad 2013-06-05 19:05:34 UTC

Thanks for patch, applied.

Date: Wed Jun  5 19:04:42 2013
New Revision: 1490008

URL: http://svn.apache.org/r1490008
Log:
Bug 55064 - Useless processing in ReportTreeListener.isValidDragAction()
Bugzilla Id: 55064

Modified:
    jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeListener.java
    jmeter/trunk/xdocs/changes.xml

Comment 2 The ASF infrastructure team 2022-09-24 20:37:54 UTC

This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3137