Bug 55065

Summary: Useless processing in Spline3.converge()
Product: JMeter Reporter: Adrian Nistor <nistor1>
Component: MainAssignee: JMeter issues mailing list <issues>
Status: RESOLVED FIXED    
Severity: normal CC: nistor1, p.mouawad
Priority: P2 Keywords: PatchAvailable
Version: 2.9   
Target Milestone: ---   
Hardware: All   
OS: All   
Attachments: patch

Description Adrian Nistor 2013-06-05 18:14:45 UTC
Created attachment 30400 [details]
patch

The problem appears in version 2.9 and in revision 1489981.  I
attached a one-line patch that fixes it.

In method "Spline3.converge", the loop from 0 to "_n" should break
immediately after "converge" is set to "false".  All the iterations
after "converge" is set to "false" do not perform any useful work
because the "if (converge)" statement will always evaluate to "false"
and the "true" branch will never be taken again for the remaining
iterations.
Comment 1 Philippe Mouawad 2013-06-05 18:59:51 UTC
Thanks for patch, applied.

Date: Wed Jun  5 18:59:09 2013
New Revision: 1490003

URL: http://svn.apache.org/r1490003
Log:
Bug 55065 - wasted work in Spline3.converge()
Bugzilla Id: 55065

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/visualizers/Spline3.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2013-06-05 19:07:27 UTC
Date: Wed Jun  5 19:06:31 2013
New Revision: 1490009

URL: http://svn.apache.org/r1490009
Log:
Bug 55065 - wasted work in Spline3.converge()
Bug renaming
Bugzilla Id: 55065

Modified:
    jmeter/trunk/xdocs/changes.xml