Summary: | BasicAuthenticator parser and associated unit tests | ||
---|---|---|---|
Product: | Tomcat 8 | Reporter: | Brian Burch <Brian> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | 8.0.x-trunk | ||
Target Milestone: | ---- | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: |
new inner class to parse credentials
remove TODOs with more tolerant parser new test class for Basic authorization parser and Base64 decoder remove redundant test cases for unusual but valid credentials |
Description
Brian Burch
2013-06-15 15:01:40 UTC
Created attachment 30436 [details]
remove TODOs with more tolerant parser
Created attachment 30437 [details]
new test class for Basic authorization parser and Base64 decoder
Thanks for the patches. They have been applied to trunk and will be included in Tomcat 8.0.0 onwards. Created attachment 30636 [details] remove redundant test cases for unusual but valid credentials r1495169 introduced a new BasicAuthenticator inner class to encapsulate parsing and decoding of Base64 credentials. It also added TestBasicAuthParser, which examines a far wider set of edge cases. This new change removes three tests that have now become complete duplicates of cases in TestBasicAuthParser. Also, the class-level comment has been expanded to explain the relationship between the two test classes. Thanks. Applied to trunk. |