Bug 55175

Summary:	HTTPHC4Impl refactoring to allow better inheritance
Product:	JMeter - Now in Github	Reporter:	Philippe Mouawad <p.mouawad>
Component:	HTTP	Assignee:	JMeter issues mailing list <issues>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	p.mouawad
Priority:	P2
Version:	Nightly (Please specify date)
Target Milestone:	---
Hardware:	All
OS:	All
Attachments:	Proposed patch Updated patch as per sebb notes

Description Philippe Mouawad 2013-07-01 15:18:35 UTC

It would be interesting to refactor slightly HTTPHC4Impl to allow inheriting classes to reuse many of already implemented and useful internals.
This would be useful to classes that wish for example to post binary content and similar stuff.

Comment 1 Philippe Mouawad 2013-07-02 10:34:20 UTC

Created attachment 30523 [details]
Proposed patch

Comment 2 Sebb 2013-07-04 12:59:55 UTC

There seem to be some spurious changes in the patch in the setupRequest method; it's difficult to work out what is actually changing.

Also there needs to be better Javadoc for the protected methods, especially if they are intended for use by 3rd party addins. If only intended for use by JMeter, then that also needs to be documented.

Comment 3 Philippe Mouawad 2013-07-06 20:39:29 UTC

Created attachment 30552 [details]
Updated patch as per sebb notes

Comment 4 Philippe Mouawad 2013-07-08 20:11:41 UTC

Date: Mon Jul  8 20:11:00 2013
New Revision: 1500926

URL: http://svn.apache.org/r1500926
Log:
Bug 55175 - HTTPHC4Impl refactoring to allow better inheritance
Bugzilla Id: 55175

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
    jmeter/trunk/xdocs/changes.xml

Comment 5 The ASF infrastructure team 2022-09-24 20:37:54 UTC

This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3153