Bug 55435

Summary: ComboStringEditor could be simplified to make most settings final
Product: JMeter Reporter: Sebb <sebb>
Component: MainAssignee: JMeter issues mailing list <issues>
Status: RESOLVED FIXED    
Severity: enhancement    
Priority: P2    
Version: 2.9   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   

Description Sebb 2013-08-16 17:55:44 UTC
The package-private ComboStringEditor can be reconfigured to change the tags, edit and undefined behaviour after creation. 

This makes the code more complicated than it needs to be. Currently JMeter does not change the settings after the class has been created, so it could be simplified by removing the setTags(), setNoEdit() and setNoUndefined() methods, replacing them with constructor parameters.
Comment 1 Sebb 2013-08-16 18:04:42 UTC
URL: http://svn.apache.org/r1514823
Log:
ComboStringEditor could be simplified to make most settings final
Bugzilla Id: 55435

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/ComboStringEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/FileEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java
    jmeter/trunk/xdocs/changes.xml