| Summary: | Startup Performance : On Startup, BeanInfoSupport should test for key availability instead of throwing | ||
|---|---|---|---|
| Product: | JMeter - Now in Github | Reporter: | Philippe Mouawad <p.mouawad> |
| Component: | Main | Assignee: | JMeter issues mailing list <issues> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | p.mouawad |
| Priority: | P2 | ||
| Version: | 2.6 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
|
Description
Philippe Mouawad
2013-12-08 14:52:04 UTC
Affects all versions up to 2.10 Date: Sun Dec 8 14:53:49 2013 New Revision: 1549033 URL: http://svn.apache.org/r1549033 Log: Bug 55858 - Startup Performance : On Startup, BeanInfoSupport should test for key availability instead of throwing Bugzilla Id: 55858 Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/BeanInfoSupport.java jmeter/trunk/xdocs/changes.xml Is the exception frequently generated? If not, checking to ensure it does not happen is likely a waste of time. Also the new code creates the string twice; this is unnecessary and somewhat fragile - the same field should be used for both to enure they are identical. If this is a frequent code pattern, there should probably be a common helper method to do the check. This is quite different from Bug 55857 where an empty string does occur frequently. 40 times. Date: Sun Dec 8 20:10:53 2013 New Revision: 1549201 URL: http://svn.apache.org/r1549201 Log: Bug 55858 - Startup Performance : On Startup, BeanInfoSupport should test for key availability instead of throwing Avoid duplicate string creation Bugzilla Id: 55858 Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/BeanInfoSupport.java Closing as no more comment. Feel free to reopen if you want me to change This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3284 |