| Summary: | ProxyBlock does not accept network addresses | ||
|---|---|---|---|
| Product: | Apache httpd-2 | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | mod_proxy | Assignee: | Apache HTTPD Bugs Mailing List <bugs> |
| Status: | NEW --- | ||
| Severity: | normal | Keywords: | PatchAvailable |
| Priority: | P2 | ||
| Version: | 2.5-HEAD | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: |
[PATCH 1/4] mod_proxy: Match resolved addresses for NoProxy too
[PATCH 2/4] mod_proxy: Split the NoProxy parameter parsing away [PATCH 1/4] mod_proxy: Rename dirconn_entry to exclude_entry [PATCH 2/4] mod_proxy: Match resolved addresses for NoProxy too [PATCH 3/4] mod_proxy: Split the NoProxy parameter parsing away [PATCH 4/4] mod_proxy: Share NoProxy parameter parsing and evaluation |
||
|
Description
Lubomir Rintel
2014-02-18 13:28:48 UTC
Created attachment 31319 [details]
[PATCH 1/4] mod_proxy: Match resolved addresses for NoProxy too
Created attachment 31320 [details]
[PATCH 2/4] mod_proxy: Split the NoProxy parameter parsing away
Created attachment 31321 [details]
[PATCH 1/4] mod_proxy: Rename dirconn_entry to exclude_entry
Created attachment 31322 [details]
[PATCH 2/4] mod_proxy: Match resolved addresses for NoProxy too
Created attachment 31323 [details]
[PATCH 3/4] mod_proxy: Split the NoProxy parameter parsing away
Created attachment 31324 [details]
[PATCH 4/4] mod_proxy: Share NoProxy parameter parsing and evaluation
The patch set reuses code that's already used for the NoProxy directive. Diffstat: docs/manual/mod/mod_proxy.xml | 14 ++-- modules/proxy/mod_proxy.c | 83 ++++++++++------------- modules/proxy/mod_proxy.h | 9 +-- modules/proxy/proxy_util.c | 67 ++++++------------ modules/proxy/proxy_util.h | 8 +-- 5 files changed, 69 insertions(+), 112 deletions(-) Glancing over the patches, they look more complex than needed... can it be simp lyfied and combined? I'm really not sure. I've did my best to avoid unnecessary complexity (there's more removals than additions in the end). I've tried not to mix unrelated changes and tried keep logical chunks in separate patches with appropriate explanations. I could definitely try to improve things you find needlessly complex or unclear, but I'd need more specific input for that. |