Summary: | JMS Publisher/Point to Point: Add JMSPriority and JMSExpiration | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Tom M. <tom_apache> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | p.mouawad, tom_apache |
Priority: | P2 | Keywords: | PatchAvailable |
Version: | 2.11 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: | Patch for org.apache.jmeter.protocol.jms.client.Publisher |
Description
Tom M.
2014-05-11 14:38:44 UTC
Created attachment 31603 [details]
Patch for org.apache.jmeter.protocol.jms.client.Publisher
Added a patch for JMS Publisher, this could be applied in a similar way to JMSSampler (Point-to-Point).
Since there are no tests yet for the package org.apache.jmeter.protocol.jms and a mock framework is yet missing in JMeter I didn't provide a unit test but the patch has been tested while using JMeter.
Thanks for patch. First I requalify this as an enhancement, as currently JMeter does not handle those 2 Headers. Regarding patch, I think integrating it as-is would be a bit disturbing as the 2 "properties" are in fact Headers, so allowing users to put them in JMS Properties would be misleading. According to: http://docs.oracle.com/javaee/1.4/tutorial/doc/JMS4.html#wp79367 I understand we are not able to set those: - JMSExpiration - JMSPriority Others being set through different ways in JMeter, by broker, or automatically. I think to be clear, we should introduce 2 custom fields in GUI between timeout and delivery as there is place and it makes sense there. Tell me if you could rework your patch, if not I will do . Thanks for contribution. (In reply to Philippe Mouawad from comment #2) > > Regarding patch, I think integrating it as-is would be a bit disturbing as > the 2 "properties" are in fact Headers, so allowing users to put them in JMS > Properties would be misleading. > The same would apply to JMSCorrelationID which can be set in the JMS Properties table although it is a header too. Moving this one to a dedicated text field could possibly break backward compatibility, so this has to be taken into account? Date: Tue Jul 1 20:54:07 2014 New Revision: 1607183 URL: http://svn.apache.org/r1607183 Log: Bug 56510 - JMS Publisher/Point to Point: Add JMSPriority and JMSExpiration Bugzilla Id: 56510 Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/Utils.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/Publisher.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSamplerGui.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/FixedQueueExecutor.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/QueueExecutor.java jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/TemporaryQueueExecutor.java jmeter/trunk/xdocs/changes.xml Hello Tom M., It would be nice if you could test nightly build when it is available and give us some feedback. Thank you Hi Philippe, sure, I will do some test, but it may take some time. I'll let you know about the results. This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3373 |