Summary: | Allow specifying file mode in <fileset> so that <tar> can use it through resource collections | ||
---|---|---|---|
Product: | Ant | Reporter: | Trejkaz (pen name) <trejkaz> |
Component: | Core tasks | Assignee: | Ant Notifications List <notifications> |
Status: | NEW --- | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux |
Description
Trejkaz (pen name)
2014-06-13 05:33:53 UTC
with the changes you propose we wouldn't necessarily need to add mode to fileset as you could still use zio/tarfileset to add the mode. In fact I think you'd probably even keep the mode through union (casting up to ArchiveResource) right now if you used tarfilesets to build up your union. The point where you lose mode information is when mappedresources comes into the mix. In addition to the changes you propose we'd also need to modify ResourceDecorator so the mode doesn't get lost. If you look into the implementation of <tar> you'll see it also has TarFileSet hardcoded when it comes to overriding the mode of resources - <zip> and the compress antlib do better here, but they still special cases ArchiveFileSet. In the end you'll probably want to add dir/filemode to ResourceCollection as well. |