Summary: | [PATCH] Example FromHowTo throws Exception after the first cell with a string | ||
---|---|---|---|
Product: | POI | Reporter: | Arturo <arturo.nospam+poi> |
Component: | XSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | trivial | ||
Priority: | P2 | ||
Version: | 3.11-dev | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Mac OS X 10.4 | ||
Attachments: | Reset the flag nextIsString since it has been successfully used |
Description
Arturo
2014-09-11 06:37:28 UTC
Looks like the example on the site was updated for this case (fix slightly different), but the example in the source tree wasn't. I've brought over the fix from the site in r1624237 - can you check if that fixes it for you? It does remind me that we should probably look at doing what a few other Apache projects have done, and have the examples only in svn as code, then pull them into the website when it gets built. That would also let us add unit tests for the examples, which'd catch things like this! Something to consider for the future... (In reply to Nick Burch from comment #1) > Looks like the example on the site was updated for this case (fix slightly > different), but the example in the source tree wasn't. I've brought over the > fix from the site in r1624237 - can you check if that fixes it for you? Yes, it totally fixed it. Thank you! > It does remind me that we should probably look at doing what a few other > Apache projects have done, and have the examples only in svn as code, then > pull them into the website when it gets built. Sounds good for people like me which don't know where is everything. :) > That would also let us add unit tests for the examples, which'd catch > things like this! Something to consider for the future... This bug can be closed. Can I do it, or you do it? Resolved as far as I see. |