| Summary: | [patch] Implement FIXED function | ||
|---|---|---|---|
| Product: | POI | Reporter: | Patrick Böker <patrick.boeker> |
| Component: | HSSF | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | Keywords: | PatchAvailable |
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Attachments: |
FIXED.diff - the patch
fixed.diff - patch with XLS based test FixedFunctionTestCaseData.xls fixed.diff - patch with XLS based test (unborked) |
||
I don't know where the information in functionMetadata.txt comes from, but in Excel 2013 and Excel 2003 the FIXED function takes 1-3 arguments. I took the best guess I had and changed the FIXED spec in BIFF4 and left the one in BIFF2 untouched. I don't know if this is correct nor how to verify this. It would be good to have sample workbooks from those Excel versions to verify that it works correctly with the different behavior in those versions. Created attachment 32186 [details]
fixed.diff - patch with XLS based test
Created attachment 32187 [details]
FixedFunctionTestCaseData.xls
This is the XLS file needed for the patch. Place it in /test-data/spreadsheet/
I viewed this XLS file in Excel 2003 and Excel 2013 and in both it looks correct.
The added XLS file shows the expected values in both Excel 2003 and Excel 2013. I don't have any other Excel Versions available to see. If someone else does, feel free to have a look. The new patch contains many more changes, looks like changes done to trunk lately are somehow included in your patch, can you roll it once more with an up-to-date working copy? Created attachment 32194 [details]
fixed.diff - patch with XLS based test (unborked)
Recreated the diff. This time only my own changes are included.
As before, the xls file needs to be included manually under test-data/spreadsheet/FixedFunctionTestCaseData.xls
Corrected patch provided. Thanks, this is applied now via r1637361 in time for 3.11beta3, I reported a bug for OpenOffice to discuss the difference in required parameters at https://issues.apache.org/ooo/show_bug.cgi?id=125837 |
Created attachment 32042 [details] FIXED.diff - the patch - Add an implementation for the FIXED function including tests. - Correct a typo. - Cosmetic: Remove "nonexistent gaps" in function array. The implementation is currently hard-wired to the US way of formatting numbers, e.g. 1,234.56 As far as I know this is true for the rest of POI also at the moment.