Bug 57164

Summary: [PATCH] XSSFDrawing.createCellComment() does not honor dx and dy values passed in
Product: POI Reporter: toni97
Component: XSSFAssignee: POI Developers List <dev>
Severity: enhancement CC: toni97
Priority: P2 Keywords: PatchAvailable
Version: 3.11-dev   
Target Milestone: ---   
Hardware: PC   
OS: All   
Attachments: suggested patch

Description toni97 2014-10-29 12:14:36 UTC
Created attachment 32164 [details]
suggested patch

XSSFDrawing.createCellComment() takes a ClientAnchor as an argument to control positioning of the created comment. While it positions the comment at the given cells it completely ignores any dx and dy values defined in the anchor and sets those to 0 on the resulting VML-drawing.

See my attached patch for how I think it should work.
Comment 1 Andreas Beeker 2014-11-16 14:54:20 UTC
Thank you for the patch.
Applied with r1639996
I've changed that patch, so that the dx/dy values are specified as EMUs (opposed to pixels) to be in line with other client anchor usages in XSSF.
I've moved the client anchor tests for xssf/hssf to the common base class.