| Summary: | [PATCH] Allow processing of non-OOXML core namespace packages | ||
|---|---|---|---|
| Product: | POI | Reporter: | virtuald <dustin> |
| Component: | POI Overall | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 58087 | ||
|
Description
virtuald
2015-01-22 17:55:01 UTC
For additional info, visio documents use the "http://schemas.microsoft.com/visio/2010/relationships/document" namespace for relationships, not "http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument", which is why this patch is required. This is a pretty simple fix, can this be merged in? Thanks! I noticed that there was a merge conflict, so I just rebased it and it's mergable again. Is there anything I can do to speed this along? Thanks! Can you also add a few unit tests which verify the changed/added code parts? This way we ensure that it does not break with future changes. Sorry for the delay, I've been on vacation the last few days... The changes should be mostly covered by existing tests that parse files that use the PackageRelationshipTypes.CORE_DOCUMENT namespace. The only thing that isn't covered is creating a POIXMLDocument with the new constructor. I suppose I could add a test case that calls the second constructor with PackageRelationshipTypes.CORE_DOCUMENT just for coverage's sake. Or do you want me to add a document that doesn't use CORE_DOCUMENT namespace to the test suite just for completeness? AFAIK the only thing that uses a non-core namespace are visio documents, and poi doesn't support them (yet), so it'd be odd to add a vsdx to the unit tests. Yes, it would be good to have a test-file which has such a different structure so we can verify that we can at least read some information from those as well. We already have some other files in the test-suite just to ensure that we can read some properties from them. We even have test files to verify that we cannot read them because they are corrupt! Sorry for the delay, was on vacation. :) Looks like there was already a vsdx file in the test data, so I've removed the non-working version of the test and added a stub for future XDGF support, which uses the behavior introduced by this patch. |