| Summary: | [PATCH] Incorrect year parsing in message submission chunk | ||
|---|---|---|---|
| Product: | POI | Reporter: | Adrian Conlon <adrian.conlon> |
| Component: | HSMF | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | Keywords: | PatchAvailable |
| Priority: | P2 | ||
| Version: | 3.10-FINAL | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Attachments: |
Generated using "ant -f patch.xml"
Generated using "ant -f patch.xml" Updated patch for problem |
||
Created attachment 32552 [details]
Generated using "ant -f patch.xml"
Second part of the patch, includes test data.
I forgot to note: patch applies to "trunk". The message submission chunk as extracted by POI HSMF appears to be: PR_MESSAGE_SUBMISSION_ID/PidTagMessageSubmissionId Documented here ([MS-OXOMSG] Section 2.2.1.79) https://msdn.microsoft.com/en-us/library/hh369838(v=exchg.80).aspx Effectively, it appears as though this property shouldn't be interpreted to extract a date. Perhaps the solution would be to ignore the message submission chunk (at least in terms of date/time extraction). Created attachment 32590 [details]
Updated patch for problem
Corrects a less/greater than mix up (sorry Nick, you were right to question that one!).
Replaces one test case with three cases covering the transition around the pivot year (1980).
Patch seems (to me) to be in a better format.
N.B.
The test cases are *manually* hacked using MFCMapi. No emails I send (using Outlook/Exchange) include the PR_MESSAGE_SUBMISSION_ID.
|
Created attachment 32551 [details] Generated using "ant -f patch.xml" Some messages sent before the year 2000 are being parsed (incorrectly!) as having been sent in the future. For the test case I'm interested in, some emails actually sent in the year 1999 are shown as having been sent in the year 2099.