Bug 58205

Summary: getSlideMasters() returns the master slides in the incorrect order
Product: POI Reporter: mark.o <Mark.Olesen>
Component: XSLFAssignee: POI Developers List <dev>
Status: RESOLVED FIXED    
Severity: normal    
Priority: P2    
Version: 3.13-dev   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Attachments: patch with proposed changes

Description mark.o 2015-08-04 08:29:14 UTC
Created attachment 32955 [details]
patch with proposed changes

- Relying on the order returned by HashMap is dubious.
  In my case it returned [slideMaster2, slideMaster1]
Comment 1 Andreas Beeker 2015-08-06 23:09:38 UTC
Hi Mark,

thank you for your patch, but please also add test files and junit tests to 
your patches (not just this one).
I'm currently trying to reproduce the issue and write a test, but it would be 
easier with at least a example .pptx

Andi
Comment 2 Andreas Beeker 2015-08-07 00:20:05 UTC
Applied the patch with a modification for a NPE in r1694592
Comment 3 mark.o 2015-08-07 06:29:29 UTC
Hi Andi,

> thank you for your patch, but please also add test files and junit tests to 
> your patches (not just this one).

OK. Test cases should now be possible (now that I've found out where to define the POI.testdata.path in netbeans). We'll see how far I manage with useful junit tests...