Bug 58253

Summary: [PATCH] Minor changes to CellReference
Product: POI Reporter: Javen O'Neal <onealj>
Component: SS CommonAssignee: POI Developers List <dev>
Status: RESOLVED FIXED    
Severity: enhancement    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Attachments: CellReference.java patch

Description Javen O'Neal 2015-08-18 03:30:51 UTC
Created attachment 33006 [details]
CellReference.java patch

A few minor changes to CellReference:

* Compare cellRefString.toUpperCase() with "#REF!" for CellReference(String)
* Change private separateRefParts(String) to return a struct instead of a 3-element String array. The goal here was to make the code easier to read and more flexible if POI supports cell references external to the workbook, though I don't know if creating an object is more expensive (time or memory) than a String array. Do we have a good way to test this?
* Update javadoc for separateRefParts
Comment 1 Nick Burch 2015-08-18 14:46:42 UTC
Thanks, patch committed in r1696430.

(Even if the string[] is a smidgen faster, readability is important to, so seems worth it)