Bug 58341

Summary:	[PATCH] Deal with a lot more edge cases in the D* functions
Product:	POI	Reporter:	Patrick Böker <patrick.boeker>
Component:	SS Common	Assignee:	POI Developers List <dev>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	PatchAvailable
Priority:	P2
Version:	3.13-dev
Target Milestone:	---
Hardware:	All
OS:	All
Attachments:	dget_polish.patch DGet.xls DGet.xls dget_polish.patch

Description Patrick Böker 2015-09-07 17:30:25 UTC

Created attachment 33076 [details]
dget_polish.patch

Deal with a lot more cases correctly. Mostly involving blank cells, cells with empty strings, data types other than string and similar. The test XLS file now has a lot more test cases explicitly testing for edge cases.

Comment 1 Patrick Böker 2015-09-07 17:31:22 UTC

Created attachment 33077 [details]
DGet.xls

Comment 2 Patrick Böker 2015-09-08 08:29:21 UTC

Created attachment 33081 [details]
DGet.xls

Should go to /test-data/spreadsheet/DGet.xls

Comment 3 Patrick Böker 2015-09-08 08:29:57 UTC

Created attachment 33082 [details]
dget_polish.patch

Comment 4 Dominik Stadler 2015-10-14 14:31:54 UTC

This is applied in latest trunk now via r1708606. Thanks for the Patch!