Summary: | Rework AreaReference implementation details and tests | ||
---|---|---|---|
Product: | POI | Reporter: | Javen O'Neal <onealj> |
Component: | SS Common | Assignee: | POI Developers List <dev> |
Status: | NEW --- | ||
Severity: | enhancement | CC: | dtn-asfbugs |
Priority: | P2 | ||
Version: | 3.13-dev | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
Bug Depends on: | 56328 | ||
Bug Blocks: | |||
Attachments: |
AreaReference.java patch
AreaReference.java.patch |
Description
Javen O'Neal
2015-09-13 10:31:57 UTC
Applied some of the internal changes from attachment 33099 [details] in r1710163. Created attachment 33198 [details] AreaReference.java.patch Rebased to r1710170. In this patch: * deprecate AreaReference(CellReference, CellReference), in favor of AreaReference(CellReference, CellReference, SpreadsheetVersion) * use static constants where ever possible * pre-allocate a fixed-length list for getAllReferencedCells * add many much-needed unit tests Remaining work: fix either the unit tests or the code For example, AreaReference("A1:B65536", EXCEL97).isWholeColumn() is false because it doesn't include dollar signs. AreaReference("A:B").isWholeColumn() is false because it doesn't include numbers. This doesn't seem like the correct behavior. |