Summary: | parameter type change in TextRun.setFontSize() | ||
---|---|---|---|
Product: | POI | Reporter: | mark.o <Mark.Olesen> |
Component: | XSLF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED WONTFIX | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 3.13-dev | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux |
Description
mark.o
2015-10-02 13:49:38 UTC
Note: SL : [sg]etFontSize uses Double SS : [sg]etFontSize uses double WP : [sg]etFontSize uses int Lets start with the javadocs for this function: "font size in points, if null the underlying fontsize will be unset" > This prevents promotion from int ... ... but fontsizes can be also specified as real numbers > Why not retain the unboxed primitives? setting the value to null will force the usage of the slidelayout value. Even worse is using something as -1 as indicator for unset values. Currently I haven't applied this logic to all methods. Whenever something is promoted to common sl, I'll adapt the handling in X/HSLF accordingly. > "font size in points, if null the underlying fontsize will be unset"
> setting the value to null will force the usage of the slidelayout value.
OK - this is now quite clear. Thanks for the explanation.
|