Bug 58546

Summary: SecureNio2Channel inner class GatherState should be static
Product: Tomcat 8 Reporter: Anthony Whitford <anthony>
Component: UtilAssignee: Tomcat Developers Mailing List <dev>
Status: RESOLVED FIXED    
Severity: trivial    
Priority: P2    
Version: 8.0.x-trunk   
Target Milestone: ----   
Hardware: Macintosh   
OS: Mac OS X 10.1   
Attachments: Makes GatherState a static inner class

Description Anthony Whitford 2015-10-25 22:52:35 UTC
Created attachment 33218 [details]
Makes GatherState a static inner class

Since GatherState does not need its parent SecureNio2Channel, the class can be made static to be leaner.

See http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC
Comment 1 Violeta Georgieva 2015-10-26 08:26:58 UTC
Hi,

Thanks for the report and the patch.
The fix is available in 8.0.x for 8.0.29 onwards

Regards,
Violeta