| Summary: | SXSSFCell.setAsActiveCell silently does nothing | ||
|---|---|---|---|
| Product: | POI | Reporter: | Javen O'Neal <onealj> |
| Component: | SXSSF | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 3.14-dev | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: | SXSSFCell.setAsActiveCell should throw an exception until it's fully implemented | ||
Added NotImplemented decorator and made method throw RuntimeException(NotImplemented) in r1717164 [1]. This didn't break the Jenkins build, which also means this isn't unit tested. http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java?annotate=1717164&diff_format=h#l569 In r1717900: Add CellAddress Sheet.getActiveCell() (previously only available in XSSFSheet, backwards-compatibility note: previously returned a String) Add void Sheet.setActiveCell(CellAddress) Add Cell.getAddress() to support this (CellAddress(Cell) could also be used) Add unit tests for Cell.setAsActiveCell() Add unit tests for Sheet.getActiveCell and Sheet.setActiveCell In summary, SXSSFCell.setAsActiveCell is now implemented! Future public methods that are not implemented should be annotated with @NotImplemented per comment 1. Updated docs in r1717901 |
Created attachment 33245 [details] SXSSFCell.setAsActiveCell should throw an exception until it's fully implemented Right now SXSSFCell silently does nothing. It should either log that it's a non-operation or throw some exception that the setAsActiveCell is not relevant or not supported for SXSSFWorkbooks, until someone can determine a better solution.