Summary: | Review/remove references to JSR77 StateManageable | ||
---|---|---|---|
Product: | Tomcat 9 | Reporter: | Konstantin Kolinko <knst.kolinko> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | minor | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | ----- | ||
Hardware: | PC | ||
OS: | All |
Description
Konstantin Kolinko
2016-01-08 15:05:49 UTC
Thoughts ========= 1. It may still be possible to support that StateManageable "interface" -- I think with a custom MBean modeler object that will provide that "state" property, -- but I do not see much point. Nobody complained since removal of "state" property in Tomcat 7. 2. isStateManageable() can be safely removed from StandardWrapper. The wrapper did not expose its start/stop methods via JMX, nor the "state" property. 3. isStateManageable() in StandardContext I think it is OK to keep it, but update a comment to say that we do not really implement JSR 77. My initial reaction was to say fix the JSR77 implementation. However, having seen that this was broken back in Tomcat 7 and that no-one has complained, my preference would be to mark anything JSR77 related deprecated in 8.0.x and remove it entirely in 9.0.x. The remains of the JSR-77 implementation have been removed from 9.0.x. And deprecated in 8.0.x for 8.0.32 onwards. |