Bug 58926

Summary:	[Patchset] Improvements for apxs
Product:	Apache httpd-2	Reporter:	Jacob Champion <jchampion>
Component:	Build	Assignee:	Apache HTTPD Bugs Mailing List <bugs>
Status:	NEW ---
Severity:	normal	CC:	urkle
Priority:	P2	Keywords:	PatchAvailable
Version:	2.5-HEAD
Target Milestone:	---
Hardware:	PC
OS:	Linux
Bug Depends on:
Bug Blocks:	43033
Attachments:	0001: apxs: fix module name fallback 0002: apxs: remove Apache 1.3 code 0003: apxs: search for module names only when activating 0004: apxs: fix whitespace problems

Description Jacob Champion 2016-01-28 00:03:04 UTC

A group of related improvements to the apxs tool.

0001: a fix to the module-name fallback search -- which I have now discovered is already submitted under PR43033. It appears to be identical to the patch submitted there, and I include it only because the later patches are based on top of it.

0002: Removal of unused code that was orphaned after httpd 1.3.

0003: The module name is only used when apxs is asked to activate a module (-a or -A), but apxs always errors out if it can't determine a module name. This patch only performs the search for a name if the user is trying to activate the module during installation.

0004: Whitespace fixes (tabs -> 8 spaces, removal of trailing whitespace). Note that the __DATA__ portion of the code is not touched by this patch.

Comment 1 Jacob Champion 2016-01-28 00:04:33 UTC

Created attachment 33497 [details]
0001: apxs: fix module name fallback

Comment 2 Jacob Champion 2016-01-28 00:04:56 UTC

Created attachment 33498 [details]
0002: apxs: remove Apache 1.3 code

Comment 3 Jacob Champion 2016-01-28 00:05:26 UTC

Created attachment 33499 [details]
0003: apxs: search for module names only when activating

Comment 4 Jacob Champion 2016-01-28 00:05:44 UTC

Created attachment 33500 [details]
0004: apxs: fix whitespace problems

Comment 5 Jacob Champion 2016-01-28 00:08:55 UTC

Note that each patch is based on the previous one (the Diff link appears to be based directly on trunk, so it's a little misleading). You can also see the full patchset at https://github.com/jchampio/httpd/commits/dev/apxs .

Comment 6 Christophe JAILLET 2016-05-16 21:08:06 UTC

*** Bug 43033 has been marked as a duplicate of this bug. ***