Summary: | [PATCH] SXSSF does not clean temporary files on .dispose() reliably | ||
---|---|---|---|
Product: | POI | Reporter: | Travis Burtrum <admin.apache> |
Component: | SXSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All |
Description
Travis Burtrum
2016-04-12 14:50:28 UTC
Thanks for the patch! Applied in r1738848. Do you think you could also write a unit test to simulate running out of disk space (might need to create some OutputStream that has a fixed size that you can easily exceed)? I took a look and did not see an easy way to do unit-testing of this particular feature. Some other unit-tests cover the "good" case of deleting the file already, the rest needs to be tested manually for now... Still setting this to fixed as the code was adjusted accordingly. |