Summary: | If HTTP post message body data has %pa% the Results Tree can't show the message | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Teemu Vesala <Teemu.Vesala> |
Component: | HTTP | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aleksandr.rekunkov, przeszotek |
Priority: | P2 | ||
Version: | 3.0 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | All | ||
Attachments: | Patch which fixes the issue |
Description
Teemu Vesala
2016-06-16 05:06:23 UTC
The problem is at the code snippet below. Returning null when the decoding fails for IllegalArgumentExpcetion prevents showing the message at all. I'd change this to return non-decoded query. I've attached the diff about that modification. It didn't add any new unit test error messages. public static String decodeQuery(String query) { if (query != null && query.length() > 0) { try { query = URLDecoder.decode(query, CHARSET_DECODE); // better ISO-8859-1 than UTF-8 } catch(IllegalArgumentException e) { log.warn("Error decoding query, maybe your request parameters should be encoded:" + query, e); return null; } catch (UnsupportedEncodingException uee) { log.warn("Error decoding query, maybe your request parameters should be encoded:" + query, uee); return null; } return query; } return null; } Created attachment 33954 [details]
Patch which fixes the issue
*** Bug 59714 has been marked as a duplicate of this bug. *** Thanks for your contribution. Date: Tue Jun 21 18:14:22 2016 New Revision: 1749583 URL: http://svn.apache.org/viewvc?rev=1749583&view=rev Log: Display original query in RequestViewHTTP when decoding fails. Based on patch by Teemu Vesala (teemu.vesala at qentinel.com) Bugzilla Id: 59712 Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java jmeter/trunk/xdocs/changes.xml *** Bug 59808 has been marked as a duplicate of this bug. *** This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4003 |