Summary: | WorkbookEvaluator.clearAllCachedResultValues() needs to propagate the action to EvaluationWorkbook and EvaluationSheet instances | ||
---|---|---|---|
Product: | POI | Reporter: | Greg Woolsey <greg.woolsey> |
Component: | XSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 3.15-dev | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: | Fix and updated unit test resource |
Description
Greg Woolsey
2016-07-07 02:42:17 UTC
This may only be an issue for cells inside a Table, referenced by Structured Reference syntax in a formula - very narrow. It appears in this new use case the cell values are calculated from the XSSFEvaluationSheet._cellCache and not from the WorkbookEvaluator cell cache, thus the need to push the clear down. Still a good idea though, to make it more obvious what needs changing when adding future cached data. Building a test case will be more work than usual, as it requires a Table and a formula cell that references something in the table that can change. Created attachment 34022 [details]
Fix and updated unit test resource
Attached a patch to propagate the cache clearing through the evaluator object tree.
Includes an updated Structured References unit test and source file. The updated test fails before the fix and passes with the fix.
This seems to be fixed based on the previous comment. Please reopen if not. |