Summary: | Forbid calls to InputStream.available | ||
---|---|---|---|
Product: | POI | Reporter: | Andreas Beeker <kiwiwings> |
Component: | POI Overall | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 3.15-dev | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | 59841 | ||
Bug Blocks: | |||
Attachments: |
replace available() calls and add forbidden-apis-check
replace available() calls and add forbidden-apis-check patch with some of the unrelated code removed patch with all of the unrelated code removed |
Description
Andreas Beeker
2016-07-23 12:11:41 UTC
Created attachment 34068 [details]
replace available() calls and add forbidden-apis-check
fix issue with PropertySet
The patch has a number of unrelated changes, whitespaces, @Test, ... can you apply those and re-base the patch, that would make reviewing much easier. Created attachment 34760 [details] patch with some of the unrelated code removed I committed some of Andi's unrelated changes from attachment 34068 [details] in r1783347 and r1783353. Some of the line numbers may be off since I deleted unrelated changes from the patch by directly editing the text file. ChunkedCipherInputStream.read needs attention. Changed from checking the return value of reading from the underlying stream from 1 to -1. I have temporarily reverted this to restore the original behavior in 1783356. This should probably have been put back into the patch that excludes the unrelated stuff, since this behavior is related to the available() changes. Created attachment 34761 [details]
patch with all of the unrelated code removed
Less than half the size of the original. Hopefully this makes it easier to review, though it still needs to be rebased to trunk.
(unrelated changes) close leaked resources in r1783362 |