Bug 60069

Summary:	SamplerCreatorFactory.getSamplerCreator has two unused parameters
Product:	JMeter - Now in Github	Reporter:	Sebb <sebb>
Component:	HTTP	Assignee:	JMeter issues mailing list <issues>
Status:	NEW ---
Severity:	enhancement	CC:	p.mouawad
Priority:	P2
Version:	3.0
Target Milestone:	---
Hardware:	All
OS:	All

Description Sebb 2016-08-30 15:40:37 UTC

The method org.apache.jmeter.protocol.http.proxy.SamplerCreatorFactory.getSamplerCreator only uses its first parameter - the two Map parameters are ignored.

The parameters could be dropped; or at least they could be documented as being ignored.

Comment 1 Sebb 2016-08-30 16:40:03 UTC

The interface method SamplerCreator.createSampler also does not need the encoding Map parameters

Comment 2 UbikLoadPack support 2016-09-03 09:15:46 UTC

Hello sebb,
If you intend to drop SamplerCreator.createSampler in the end, then you should first deprecate the one with 2 parameters and make it call the new one in next release , then drop the deprecated one in N+2 release.
Otherwise it will break plugins, for example we would be concerned by such modification.

Thank you for taking into account this request.

Regards

Comment 3 The ASF infrastructure team 2022-09-24 20:38:05 UTC

This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4083