Summary: | JMeter 3.0 embedded resource URL is silently encoded | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Stuart Barlow <stuart.barlow> |
Component: | HTTP | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | p.mouawad |
Priority: | P2 | ||
Version: | 3.0 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | All | ||
Attachments: |
Simple test plan with HTTPRequest configured to download embedded resources
Patch proposal to fix issue |
Description
Stuart Barlow
2016-09-05 10:06:38 UTC
Hi, Thanks for opening the bug and providing test case. I'll try to analyze it asap this week. Regards Hello, Your issue is due to fix of Bug 58137. It appears an url containing + is valid, our processing to escapeIllegal leads to the change from + to %20. I think we should switch this part of code to use : https://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/UrlValidator.html But anyway I tested using org.apache.commons.validator.routines.UrlValidator#isValid and your URL appears no to be. I asked a question on commons user mailing list. "Question about URLValidator#isValid" Once I get an answer we'll see what to do. Regards Created attachment 34230 [details]
Patch proposal to fix issue
Author: pmouawad Date: Sun Sep 11 13:39:13 2016 New Revision: 1760249 URL: http://svn.apache.org/viewvc?rev=1760249&view=rev Log: Bug 60084 - JMeter 3.0 embedded resource URL is silently encoded Bugzilla Id: 60084 Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/TestHTTPUtils.java jmeter/trunk/xdocs/changes.xml Those updates fixed the problem. Thank you Philippe. This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4090 |