|Summary:||Rewrite's redirect implementation does not correspond to the documentation|
|Product:||Tomcat 8||Reporter:||Michael Osipov <michaelo>|
|Component:||Catalina||Assignee:||Tomcat Developers Mailing List <dev>|
|Attachments:||Patch for aligning the implementation to the documentation|
Description Michael Osipov 2016-11-24 09:01:25 UTC
Comment 1 Michael Osipov 2016-11-24 09:03:00 UTC
Basically, symbolic names are not implemented and result in a NumberFormatException. Attached is a patch which aligns implementation with the documentation along with doc updates and unit tests.
Comment 2 Michael Osipov 2016-11-24 09:03:34 UTC
Created attachment 34472 [details] Patch for aligning the implementation to the documentation
Comment 3 Michael Osipov 2016-11-24 09:04:56 UTC
The patch is based on mod_rewrite.c code https://github.com/apache/httpd/blob/fbc5e20ead005fd3a2bec05924f9e90dfd195406/modules/mappers/mod_rewrite.c#L3668-L3681
Comment 4 Mark Thomas 2016-11-28 11:58:38 UTC
Thanks for the report and the patch. Fixed in: - trunk for 9.0.0.M14 onwards - 8.5.x for 8.5.9 onwards - 8.0.x for 8.0.40 onwards 7.0.x and earlier are not affected as the RewriteValve is not present in those versions. The patch was applied with some minor changes to replaces tabs with 4 spaces and to align formatting with the existing code.