Summary: | SlowQueryReport causing connection leak | ||
---|---|---|---|
Product: | Tomcat Modules | Reporter: | mark.housel |
Component: | jdbc-pool | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | major | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | All |
Description
mark.housel
2017-02-22 01:40:58 UTC
Hi. Does this problem affect only when using SlowQueryReport? According to my initial investigation, the same problems seems to be occurred even if StatementCache or StatementDecoratorInterceptor is used. (In reply to Keiichi Fujino from comment #1) > Hi. > > Does this problem affect only when using SlowQueryReport? > According to my initial investigation, the same problems seems to be occurred > even if StatementCache or StatementDecoratorInterceptor is used. You are right, I just tested using StatementCache and got the same problem. When I said it only happens with SlowQueryReport, I just meant that it didn't happen when I don't use SlowQueryReport. Thanks. I am planning to fix this problem as follows. -Implement equals() and hashCode() in the StatementDecoratorInterceptor. -Enable StatementDecoratorInterceptor by default.(mybe configuable) As a result, Interceptor chain will be follows. DisposableConnectionFacade -> StatementDecoratorInterceptor -> XXXInterceptor(1..n) -> ProxyConnection Fixed at r1788183 The fix will be in : - 9.0.x for 9.0.0.M19 onwards - 8.5.x for 8.5.13 onwards - 8.0.x for 8.0.43 onwards - 7.0.x for 7.0.77 onwards The fix has changed to adding a facade on statement instead of modify StatementDecoratorInterceptor. As a result, Interceptor chain will be follows. DisposableConnectionFacade -> StatementFacade -> XXXInterceptor(1..n) -> ProxyConnection |