| Summary: | Document building and testing issues in corporate environments | ||
|---|---|---|---|
| Product: | JMeter - Now in Github | Reporter: | Michael Osipov <michaelo> |
| Component: | Main | Assignee: | JMeter issues mailing list <issues> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | enricjaen, p.mouawad, volcanic.ws |
| Priority: | P2 | ||
| Version: | 3.1 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 60883 | ||
| Attachments: |
Add proxy settings to ant download tasks
Add proxy settings to ant download tasks |
||
|
Description
Michael Osipov
2017-03-17 20:59:07 UTC
I have added the usage of ANT_OPTS. Is the patch really needed, when that environment entry is set? Date: Fri Mar 17 21:20:45 2017 New Revision: 1787505 URL: http://svn.apache.org/viewvc?rev=1787505&view=rev Log: Mention the usage of ANT_OPTS to use a proxy in the building instructions. Bugzilla Id: 60886 Modified: jmeter/trunk/README.md jmeter/trunk/xdocs/building.xml While it looks OK, it recommends a bad practice: -Dhttp.pass=xxxxx You expose your password to everyone running top. Very bad idea. Created attachment 34842 [details]
Add proxy settings to ant download tasks
Add proxy settings to the download_tasks, so that the environment entries are not repeated in something like top or ps.
*** Bug 53709 has been marked as a duplicate of this bug. *** Created attachment 34843 [details]
Add proxy settings to ant download tasks
Should stop coding for today. Now the complete patch (hopefully).
(In reply to Felix Schumacher from comment #5) > Created attachment 34843 [details] > Add proxy settings to ant download tasks > > Should stop coding for today. Now the complete patch (hopefully). Looks good to me. I will test tomorrow and let you know. Tested the patch. Works like a chimp. Please revert r1787505, it contains obsolete information. The following PR contains necessary information to make tests pass w/o Internet access: https://github.com/apache/jmeter/pull/284 This is not the best solution, but it does its job now and everyone can contribute. The best solution would either be to pass proxy to the testplans or run an embedded Jetty to mimic necessary behavior. This is what we do in Maven Wagon. Some README.md updates for the PR are necessary too. WDYT? Command line: ant test -Dskip.bug52310=true -Dskip.bug60607=true -Dskip.batchtest_Http4ImplPreemptiveBasicAuth=true -Dskip.batchtest_SlowCharsFeature=true -Dskip.batchtest_TestKeepAlive=true -Dskip.test_http=true -Dskip.test_TestDNSCacheManager.testWithCustomResolverAnd1Server=true Date: Thu Mar 23 20:44:50 2017 New Revision: 1788319 URL: http://svn.apache.org/viewvc?rev=1788319&view=rev Log: Build improvements to better enable builds in environments that are behind a proxy. Bugzilla Id: 60886 Modified: jmeter/trunk/README.md jmeter/trunk/build.xml jmeter/trunk/xdocs/building.xml jmeter/trunk/xdocs/changes.xml Date: Thu Mar 23 21:07:53 2017 New Revision: 1788325 URL: http://svn.apache.org/viewvc?rev=1788325&view=rev Log: Add properties to skip tests, that fail in environments without proper internet access, ie. are behind a proxy. Contributed by Michael Osipov. Bugzilla Id: 60886 Modified: jmeter/trunk/README.md jmeter/trunk/build.xml jmeter/trunk/test/src/org/apache/jmeter/protocol/http/control/TestDNSCacheManager.java jmeter/trunk/xdocs/building.xml jmeter/trunk/xdocs/changes.xml Thanks for your patches and feedback and I hope this enables your builds in your environment. Way better now. You forgot to document the proxy.use=true property in the RADME.md file. Date: Fri Mar 24 18:58:07 2017 New Revision: 1788530 URL: http://svn.apache.org/viewvc?rev=1788530&view=rev Log: Add docs for property proxy.use and change Michael's email. Bugzilla Id: 60886 Modified: jmeter/trunk/README.md jmeter/trunk/xdocs/building.xml jmeter/trunk/xdocs/changes.xml *** Bug 60435 has been marked as a duplicate of this bug. *** This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/4339 |