Bug 60932

Summary: Invalid or incomplete escaping of apostrophe (') in messages passed to MessageFormat
Product: Tomcat 8 Reporter: Michael Osipov <michaelo>
Component: CatalinaAssignee: Tomcat Developers Mailing List <dev>
Severity: trivial    
Priority: P2    
Version: 8.5.x-trunk   
Target Milestone: ----   
Hardware: All   
OS: All   
Attachments: Apostrophe escaping

Description Michael Osipov 2017-03-29 14:02:08 UTC
Created attachment 34885 [details]
Apostrophe escaping

Based on: https://github.com/apache/tomcat85/pull/7#discussion_r108534666

Several messages passed to MessageFormat include apostrophes which are interpreted by MF, unfortunately they are not escaped which means -- according to Javadoc -- the content between is printed literally. Two single quotes escape to one single quote after interpolation.

See attached patched for updated properties files. Changes apply only to messages which contain format elements. Please review and say whether updated strings are now as intended. 

Patch done of Tomcat 8.5 trunk.
Comment 1 Mark Thomas 2017-03-29 21:35:04 UTC
Thanks for the patch. I've applied it to 9.0.x along with a bunch of similar issues I found. I will back-port it but probably tomorrow.
Comment 2 Mark Thomas 2017-03-30 10:24:55 UTC
Fixed in:
- trunk for 9.0.0.M20 onwards
- 8.5.x for 8.5.14 onwards
- 8.0.x for 8.0.44 onwards
- 7.0.x for 7.0.78 onwards