| Summary: | Enhance the documentation for mbeans-descriptors.xml | ||
|---|---|---|---|
| Product: | Tomcat 9 | Reporter: | Alexis Hassler <alexis.hassler> |
| Component: | Documentation | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | kap.kumar88 |
| Priority: | P2 | Keywords: | Beginner |
| Version: | unspecified | ||
| Target Milestone: | ----- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: |
Updated mbeans-descriptors-howto.xml
Updated patch file for individual file as suggested. |
||
|
Description
Alexis Hassler
2017-06-26 05:38:46 UTC
the MBeans Descriptors How To xml file has been updated. You need to attach a patch with your updates to this bug report for review. http://www.apache.org/dev/contributors.html#patches Created attachment 35469 [details]
Updated mbeans-descriptors-howto.xml
Updated mbeans-descriptors-howto.xml
Hope this helps, let me know for any further refinements, suggestions, recommendations.
Restore state to the correct value. NEEDINFO is used when more information is required from the OP which is not the case here. Patches should be provided in diff -u format. I also suggest you try building the documentation and reviewing the output. It isn't going to be what you think it is. Created attachment 35489 [details]
Updated patch file for individual file as suggested.
Updated patch file for individual file as suggested.
The patch file provided is not in diff -u format. I'd expect it to look like this: http://people.apache.org/~markt/patches/applied/2008-10-30-bug44494-regression.patch I'll also repeat my recommendation from comment #4 I suggest you try building the documentation and reviewing the output. It isn't going to be what you think it is. To be explicit, the format of the proposed change is broken. The rules for rendering whitespace in HTML mean that there will be a single block of unformatted text - not the table you intend. In the end, I opted to simple copy the DTD to the docs and provide a link. I thought that was better then duplicating large sections of the comments from the DTD. Fixed in: - trunk for 9.0.3 onwards - 8.5.x for 8.5.25 onwards - 8.0.x for 8.0.49 onwards - 7.0.x for 7.0.84 onwards |