Bug 62641

Summary: libtool invocations should use --tag=CC
Product: Tomcat Native Reporter: Michael Osipov <michaelo>
Component: LibraryAssignee: Tomcat Developers Mailing List <dev>
Status: RESOLVED FIXED    
Severity: major CC: michaelo
Priority: P2    
Version: 1.2.17   
Target Milestone: ---   
Hardware: All   
OS: HP-UX   
Bug Depends on: 62640    
Bug Blocks:    
Attachments: Patch --tag=CC

Description Michael Osipov 2018-08-20 15:44:08 UTC
Created attachment 36104 [details]
Patch --tag=CC

This is a spinoff of https://bz.apache.org/bugzilla/show_bug.cgi?id=62640.

If you use libtool on a different environment libtcnative is not properly linked against libapr. If you use an external libtool it complains that tag is missing:

> libtool --silent --mode=link  aCC -Ae -g -mt   -DHAVE_CONFIG_H  -DHPUX11 -D_REENTRANT -D_HPUX_SOURCE -D_LARGEFILE64_SOURCE   -g -DHAVE_OPENSSL   -I./include -I/opt/java8/include -I/opt/java8/include/hpux -I/opt/openssl/include  -I/opt/apr/include   -version-info 2:17:2    -o libtcnative-1.la -rpath /usr/local/lib/hpux32 src/address.lo src/bb.lo src/dir.lo src/error.lo src/file.lo src/info.lo src/jnilib.lo src/lock.lo src/misc.lo src/mmap.lo src/multicast.lo src/network.lo src/os.lo src/poll.lo src/pool.lo src/proc.lo src/shm.lo src/ssl.lo src/sslconf.lo src/sslcontext.lo src/sslinfo.lo src/sslnetwork.lo src/sslutils.lo src/stdlib.lo src/thread.lo src/user.lo os/unix/system.lo os/unix/uxpipe.lo -L/opt/openssl/lib -Wl,+b: -lssl -lcrypto -L/usr/local/lib/hpux32  /opt/apr/lib/libapr.la -lrt -lm  -lpthread
> libtool: link: unable to infer tagged configuration
> libtool:   error: specify a tag with '--tag'
> Makefile:89: recipe for target 'libtcnative-1.la' failed
> gmake[1]: *** [libtcnative-1.la] Error 1
> gmake[1]: Leaving directory '/tmp/tomcat-native-1.2.17-src/native'
> /tmp/tomcat-native-1.2.17-src/native/build/rules.mk:118: recipe for target 'all-recursive' failed
> gmake: *** [all-recursive] Error 1

Attached is a patch which fixes the issue.
Comment 1 Michael Osipov 2018-08-21 08:17:14 UTC
Fixed with r1838527 for 1.2.18 and newer.