Bug 62806

Summary: ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode
Product: JMeter Reporter: UbikLoadPack support <support>
Component: MainAssignee: JMeter issues mailing list <issues>
Status: RESOLVED FIXED    
Severity: major CC: p.mouawad
Priority: P2 Keywords: FixedInTrunk
Version: 2.13   
Target Milestone: JMETER_5.1   
Hardware: All   
OS: All   
Attachments: Test plan screenshot

Description UbikLoadPack support 2018-10-08 09:09:56 UTC
Created attachment 36191 [details]
Test plan screenshot

Hello,
Working with 3rd party plugin we noticed a difference in behaviour between GUI and NON GUI mode.

One particular 3rd party component that implemented NoThreadClone was behaving in a wrong way in NON GUI Mode.
See:
- https://groups.google.com/forum/#!topic/jmeter-plugins/YEU-nstQ4oc

After further analysis it appears issue is in Core JMeter .
When running a test in GUI mode , a clone tree withour honouring NoThreadClone happens:

- https://github.com/apache/jmeter/blob/v5_0/src/core/org/apache/jmeter/gui/action/Start.java#L205

But in GUI mode, so such thing happens.

This triggers an issue when you use at least twice a ModuleController that references a Component that implements NoThreadClone.

In the attached test plan, we have:
- TG-Participant1-Input using a ModuleController-Sender referencing Simple-Controller-Referenced
- TG-Participant2-Input using a ModuleController-Sender referencing Simple-Controller-Referenced

We end up having in NON GUI only 1 instance of NoThreadClone-Element while in GUI mode we have 2.
Comment 1 Philippe Mouawad 2018-10-08 14:58:24 UTC
Author: pmouawad
Date: Mon Oct  8 14:57:46 2018
New Revision: 1843158

URL: http://svn.apache.org/viewvc?rev=1843158&view=rev
Log:
BUG 62806 : ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode
Contributed by UbikLoadPack
Bugzilla Id: 62806

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/RemoteStart.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Start.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2018-11-06 14:04:46 UTC
Author: pmouawad
Date: Tue Nov  6 13:39:15 2018
New Revision: 1845917

URL: http://svn.apache.org/viewvc?rev=1845917&view=rev
Log:
Bug 62806 ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode.
Reinstate old method signature to avoid NoSuchMethodError in calling plugins and deprecate it
Bugzilla Id: 62806

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/JMeter.java