Bug 62885

Summary: AccessLogSampler Parser for AWS load balancer
Product: JMeter Reporter: paulca <paul.carr>
Component: MainAssignee: JMeter issues mailing list <issues>
Status: NEEDINFO ---    
Severity: enhancement CC: p.mouawad
Priority: P2    
Version: 5.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Add more http methods for parsing log files

Description paulca 2018-11-05 14:00:31 UTC
Hi , I've just found your access log sampler, and think it's fantastic. I can now run a load test from prod in QA , which is great.

I then thought I'd do the same with our AWS site , and discovered the standard parsers do not handle the AWS ALB log format very well. I've attached a small snippet of an AWS ALB access log .... any chance you could knock up a parser for it ?
Comment 1 paulca 2018-11-05 14:01:26 UTC
Created attachment 36244 [details]
Comment 2 Felix Schumacher 2018-11-08 19:03:00 UTC
Can you elaborate a bit more on what is not working for you? Is it the OPTIONS http verb or something entirely different?
Comment 3 Felix Schumacher 2018-11-08 19:47:25 UTC
Created attachment 36252 [details]
Add more http methods for parsing log files

The attached patch adds all the http methods, that are available in the HTTPSamplerBase. OPTIONS is one of them, so the AWS log files should be parseable with this patch.
Comment 4 Philippe Mouawad 2018-11-08 21:27:06 UTC
Hi Felix, 
Thanks for the patch.
Wouldn't it be an occasion to rename the TCLogParser so that they respect naming conventions ? 
Maybe before applying the patch so that it's clear ?

Comment 5 Felix Schumacher 2018-11-09 20:59:51 UTC
Renaming is probably not a good idea, since the class seems to be intended to be used for subclassing.

Having slept a night about the changes, I am not so sure anymore, that is OK to add more methods by default, as those could change existing tests. So I think it would be better to introduce a new property that allows more methods, or add a variable to the bean, that would be used for configuration.