Summary: | RemoteIpValve: Multiple forwards in X-Forwarded-Proto header not supported | ||
---|---|---|---|
Product: | Tomcat 9 | Reporter: | Tom Groot <t-groot> |
Component: | Catalina | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | t-groot |
Priority: | P2 | Keywords: | PatchAvailable |
Version: | unspecified | ||
Target Milestone: | ----- | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Patch incl. test cases to support multiple forwarded protocols in X-Forwarded-Proto header value.
Fixes typo / copy paste mistake in test method names. |
Description
Tom Groot
2018-12-05 12:52:41 UTC
Created attachment 36291 [details]
Patch incl. test cases to support multiple forwarded protocols in X-Forwarded-Proto header value.
Thanks for the report, test cases and patch. As bug reports go, this one was ideal. Fixed in: - trunk for 9.0.14 onwards - 8.5.x for 8.5.36 onwards - 7.0.x for 7.0.93 onwards I also applied a very similar patch to the RemoteIpFilter that uses almost identical code. Created attachment 36314 [details]
Fixes typo / copy paste mistake in test method names.
Hi Mark,
Thanks a lot for the quick response and also for taking care of the filter i didn't know of.
I have to apologize, i noticed now that when copy-pasting these endlessly long names of the test methods i failed to adjust some of them properly, hence this small follow-up patch. In cases where the mock request is prepared as http, the test method name said it was https. It should not matter too much, it would just be to avoid confusion if someone wanted to make sense of the tests.
Sorry,
tom
Patch applied. Thanks for the attention to detail. It is much appreciated. |