Bug 63056

Summary: JspC ignores uriroot property as of Tomcat 9.0.14 / 8.5.37
Product: Tomcat 9 Reporter: Adam Rauch <adam>
Component: JasperAssignee: Tomcat Developers Mailing List <dev>
Status: RESOLVED FIXED    
Severity: normal CC: appe.raja, dimdol, philippe.ruffinoni, zach
Priority: P2    
Version: 9.0.14   
Target Milestone: -----   
Hardware: PC   
OS: All   
Attachments: Archive with simple jsp and bash script

Description Adam Rauch 2019-01-04 03:03:30 UTC
Created attachment 36364 [details]
Archive with simple jsp and bash script

Starting with 9.0.14 and 8.5.37, JspC seems to ignore the value of the "uriroot" (aka "webroot") property, as mentioned in post http://mail-archives.apache.org/mod_mbox/tomcat-users/201901.mbox/%3C0317090c-2fab-e04c-1450-6b9ebe0beae7%40labkey.com%3E

This change breaks the JSP pre-compilation step of our build, and likely others that use the pattern shown in the JspC JavaDoc example configuration: https://tomcat.apache.org/tomcat-8.5-doc/api/org/apache/jasper/JspC.html

I've attached a .tgz archive that contains a simple jsp and a bash script that illustrate the problem.

The command line used in that bash script is: 

java -cp /usr/local/apache-tomcat-9.0.14/lib/jasper.jar:/usr/local/apache-tomcat-9.0.14/lib/jasper-el.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-util.jar:/usr/local/apache-tomcat-9.0.14/lib/jsp-api.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-jni.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-api.jar:/usr/local/apache-tomcat-9.0.14/lib/servlet-api.jar:/usr/local/apache-tomcat-9.0.14/lib/tomcat-util-scan.jar:/usr/local/apache-ant-1.9.13/lib/ant.jar:/usr/local/apache-tomcat-9.0.14/bin/tomcat-juli.jar:/usr/local/apache-tomcat-9.0.14/lib/el-api.jar org.apache.jasper.JspC -source 11 -target 11 -d output -webapp webapp

Thanks,
Adam
Comment 1 Mark Thomas 2019-01-04 17:07:42 UTC
Thanks for the report and the test case. Fixed in:
- 9.0.x for 9.0.15 onwards
- 8.5.x for 8.5.38 onwards

7.0.x is not affected.
Comment 2 Adam Rauch 2019-01-04 21:20:39 UTC
FWIW: I built Tomcat from trunk sources and performed a clean build of our webapp against this version. JSPs are now getting translated into .java files and compiled. I'll test again on the next official Tomcat releases, but this looks very promising.

Thanks, Mark, for the fix and the fast turnaround!
Comment 3 Mark Thomas 2019-01-11 16:51:28 UTC
*** Bug 63076 has been marked as a duplicate of this bug. ***
Comment 4 Mark Thomas 2019-01-25 17:22:49 UTC
*** Bug 63115 has been marked as a duplicate of this bug. ***
Comment 5 Mark Thomas 2019-01-28 12:18:33 UTC
*** Bug 63120 has been marked as a duplicate of this bug. ***
Comment 6 Rainer Jung 2019-01-29 09:46:56 UTC
*** Bug 63123 has been marked as a duplicate of this bug. ***