Bug 63141

Summary: Make sure that translations of script interface preserve "OK -" prefix in response text
Product: Tomcat 9 Reporter: Konstantin Kolinko <knst.kolinko>
Component: ManagerAssignee: Tomcat Developers Mailing List <dev>
Status: RESOLVED FIXED    
Severity: regression    
Priority: P2    
Version: 9.0.14   
Target Milestone: -----   
Hardware: PC   
OS: All   

Description Konstantin Kolinko 2019-02-04 11:45:19 UTC
The Ant tasks that communicate with Manager and Host Manager web applications expect that the first line of a successful response starts with "OK -" literally.

See AbstractCatalinaTask.java

> if (!line.startsWith("OK -")) {

As I am looking at translations (at Russian translation, to be specific), I see that some translations break this convention. E.g. I see that sometime it uses "OK-" instead of "OK -".


Maybe the tool that is used to import translations into Tomcat source can check that the "OK -" prefix is preserved.
Comment 1 Michael Osipov 2019-02-04 12:45:00 UTC
I'd rather see the manager having a proper REST interface with status codes and supplemental JSON responses. I, too, have to parse the messages.
Comment 2 Mark Thomas 2019-02-04 14:21:00 UTC
Fixed all the current strings and added a test case to check them going forwards.