Summary: | LDAP related elements: Add option to implicitly trust SSL/TLS connections/Disable hostname verification | ||
---|---|---|---|
Product: | JMeter | Reporter: | Brian Wolfe <wolfebrian2120> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | p.mouawad |
Priority: | P2 | Keywords: | FixedInTrunk |
Version: | 3.2 | ||
Target Milestone: | JMETER_5.1.1 | ||
Hardware: | All | ||
OS: | All |
Description
Brian Wolfe
2019-02-17 20:54:57 UTC
I created pull request #443 with branch 63185. This pull request addresses the LDAP trust all feature for the Extended LDAP Request Sampler. It is currently awaiting review and a decision on when the feature can be merged for a release. Author: pmouawad Date: Fri Mar 1 10:03:02 2019 New Revision: 1854570 URL: http://svn.apache.org/viewvc?rev=1854570&view=rev Log: Bug 63185 - Add option to implicitly trust SSL/TLS connections/Disable hostname verification Based on contribution by Brian Wolfe Changes: - Fixed existing NPE if log level is DEBUG if attr is null - Fixed some SONAR warning - Simplified code - Modified TrustAllSocketFactory (renamed and fixed static attribute sf affectation from Constructor) This closes #443 Bugzilla Id: 63185 Added: jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/TrustAllSocketFactory.java (with props) Modified: jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties jmeter/trunk/src/core/org/apache/jmeter/resources/messages_es.properties jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties jmeter/trunk/src/core/org/apache/jmeter/resources/messages_pt_BR.properties jmeter/trunk/src/core/org/apache/jmeter/resources/messages_tr.properties jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/config/gui/LdapExtConfigGui.java jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LdapExtClient.java jmeter/trunk/xdocs/changes.xml jmeter/trunk/xdocs/usermanual/build-ldapext-test-plan.xml jmeter/trunk/xdocs/usermanual/component_reference.xml Thanks wolfebrian2120 for your contribution. It is now merged but I made modifications. Can you checkout the currently building jenkins if it's successful: https://builds.apache.org/job/JMeter-trunk/ Test and give us feedback. Also, it would be better to make in GUI, Trust All only enabled if "Use Secure LDAP Protocol" is enabled as it is only used then. Thanks |